Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Deep Linking - Issue with <a> tag in index.html #3870

Closed
abilashgt opened this issue Sep 4, 2013 · 3 comments
Closed

Deep Linking - Issue with <a> tag in index.html #3870

abilashgt opened this issue Sep 4, 2013 · 3 comments

Comments

@abilashgt
Copy link

"#/" is missing in front of the links in index.html for http://docs.angularjs.org/cookbook/deeplinking:

[ Welcome | Settings ]

Solution code:
The above line in index.html becomes:

[ Welcome | Settings ]

@ghost ghost assigned petebacondarwin Sep 21, 2013
@jamesdaily
Copy link
Contributor

Here's a Plunker with an enhanced example: http://plnkr.co/edit/n5DAbB?p=preview

  • proper "#/" linking
  • ability to add / remove contacts
  • slightly more semantic dom

If no one objects, I can issue a pull request to implement these changes.

Still to-do: update the end to end test conditions

I should note - overall I think this demo misses the mark for demoing deep linking - the majority of the code is to support the app functionality, not to implement particularly interesting deep linking. Thoughts?

@petebacondarwin
Copy link
Contributor

Please do submit a PR, make sure you have a good commit message, etc, etc.

jamesdaily added a commit to jamesdaily/angular.js that referenced this issue Sep 24, 2013
Add "#/" linking
Implement ability to add / remove contacts
Use semantic tags

Closes angular#3870
jamesdaily added a commit to jamesdaily/angular.js that referenced this issue Sep 24, 2013
Add "#/" linking
Implement ability to add and remove contacts
Use semantic tags

Closes angular#3870
@petebacondarwin
Copy link
Contributor

Moving discussion to PR #4146

jamesdaily added a commit to jamesdaily/angular.js that referenced this issue Sep 29, 2013
Correct "#/" linking
Implement ability to add and remove contacts
Use semantic tags
Include working e2e tests

Closes angular#3870
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.