Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Revert transclusion commits #3640

Closed
wants to merge 2 commits into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Aug 17, 2013

Reverted ngView commit: 87405e2
Reverted ngInclude commit: 1b5bee4

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@rodyhaddad
Copy link
Contributor

@matsko would it be possible to know why these changes were made in the first place?
What issue did they solve?

@matsko
Copy link
Contributor Author

matsko commented Aug 18, 2013

@rodyhaddad we were trying to make ngInclude work on the same element as ngRepeat and avoiding a memory leak for when expressions are placed inside of a ngView element when the application starts. Turns out that ngRepeat is too much to deal with and ngInclude and ngView should both be consistent if one of them will be reverting.

@ghost ghost assigned mhevery Aug 19, 2013
@mhevery
Copy link
Contributor

mhevery commented Aug 19, 2013

MERGED

@mhevery mhevery closed this Aug 19, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants