Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngInclude breaks in ngSwitch #3650

Closed
patrickrs opened this issue Aug 19, 2013 · 5 comments
Closed

ngInclude breaks in ngSwitch #3650

patrickrs opened this issue Aug 19, 2013 · 5 comments

Comments

@patrickrs
Copy link

With 1.2.0rc1, ngIncludes inside a ngSwitch does not render. Possibly related to #3584.

An previous working example when changed from 1.1.5 to 1.2.0rc1 no longer works:
http://plnkr.co/edit/o29Ybe?p=preview

@patrickrs
Copy link
Author

Pulled current mainline and added reverts from PR #3640. Expected functionality across app is now as expected. Consider closing upon merge of PR.

@mhevery
Copy link
Contributor

mhevery commented Aug 19, 2013

Will not fix. The issue is that both ng-include and ng-switch need transclusion. This used to work before animations but transclusion is required for animation.

Work around place extra div between ng-include and ng-switch.

@mhevery mhevery closed this as completed Aug 19, 2013
@patrickrs
Copy link
Author

I updated the example with the suggested workaround but it doesn't seem to work. Perhaps I am misunderstanding what the workaround should be: http://plnkr.co/edit/fCu5Pu?p=preview?

@benschwarz
Copy link

@mhevery This worked on every other release of angular. How is that a will not fix?

@valentinvieriu
Copy link

@patrickrs I think this is related to bug #3627 and they say it is fixed in the snapshot version. I think you are testing in a old version. Try using the snapshot version : http://code.angularjs.org/snapshot/angular.min.js and you will see that your example works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants