turn on EcmaScript5 strict mode

Rakefile

@@ -188,12 +188,15 @@ task :compile => [:init, :compile_scenario, :compile_jstd_scenario_adapter, :gen
 
   File.open(path_to('angular.js'), 'w') do |f|
     concat = 'cat ' + deps.flatten.join(' ')
-    f.write(%x{#{concat}})
+    f.write(%x{#{concat}}.
+              gsub(/^\s*['"]use strict['"];?\s*$/, ''). # remove all file-specific strict mode flags
+              gsub(/'USE STRICT'/, "'use strict'"))     # rename the placeholder in angular.prefix
     f.write(gen_css('css/angular.css', true))
   end
 
   %x(java -jar lib/closure-compiler/compiler.jar \
         --compilation_level SIMPLE_OPTIMIZATIONS \
+        --language_in ECMASCRIPT5_STRICT \
         --js #{path_to('angular.js')} \
         --js_output_file #{path_to('angular.min.js')})
 end

lib/closure-compiler/version.txt

@@ -1 +1 @@
-20110322
+20110615

src/Angular.js

@@ -1,3 +1,5 @@
+'use strict';
+
 ////////////////////////////////////
 
 if (typeof document.getAttribute == $undefined)
@@ -115,7 +117,7 @@ var _undefined        = undefined,
     angularCallbacks  = extensionMap(angular, 'callbacks'),
     nodeName_,
     rngScript         = /^(|.*\/)angular(-.*?)?(\.min)?.js(\?[^#]*)?(#(.*))?$/,
-    uid               = ['0', '0', '0'];
+    uid               = ['0', '0', '0'],
     DATE_ISOSTRING_LN = 24;
 
 /**

src/AngularPublic.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var browserSingleton;
 /**
  * @workInProgress

src/Browser.js

@@ -1,3 +1,5 @@
+'use strict';
+
 //////////////////////////////
 // Browser
 //////////////////////////////

src/Compiler.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Template provides directions an how to bind to a given element.
  * It contains a list of init functions which need to be called to

src/Injector.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @ngdoc function
  * @name angular.injector
@@ -73,8 +75,9 @@ function createInjector(factoryScope, factories, instanceCache) {
   }
 }
 
-/*NOT_PUBLIC_YET
- * @ngdoc function
+/**
+ * THIS IS NOT PUBLIC DOC YET!
+ *
  * @name angular.annotate
  * @function
  *

src/JSON.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var array = [].constructor;
 
 /**

src/Resource.js

@@ -1,3 +1,5 @@
+'use strict';
+
 
 
 function Route(template, defaults) {

src/Scope.js

@@ -1,3 +1,5 @@
+'use strict';
+
 function getter(instance, path, unboundFn) {
   if (!path) return instance;
   var element = path.split('.');

src/angular-bootstrap.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * The MIT License
  *

src/angular-mocks.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * The MIT License
  *
@@ -516,15 +518,16 @@ function TzDate(offset, timestamp) {
   };
 
   //hide all methods not implemented in this mock that the Date prototype exposes
-  var unimplementedMethods = ['getMilliseconds', 'getTime', 'getUTCDay',
+  var self = this,
+      unimplementedMethods = ['getMilliseconds', 'getUTCDay',
       'getUTCMilliseconds', 'getYear', 'setDate', 'setFullYear', 'setHours', 'setMilliseconds',
       'setMinutes', 'setMonth', 'setSeconds', 'setTime', 'setUTCDate', 'setUTCFullYear',
       'setUTCHours', 'setUTCMilliseconds', 'setUTCMinutes', 'setUTCMonth', 'setUTCSeconds',
       'setYear', 'toDateString', 'toJSON', 'toGMTString', 'toLocaleFormat', 'toLocaleString',
       'toLocaleTimeString', 'toSource', 'toString', 'toTimeString', 'toUTCString', 'valueOf'];
 
   angular.forEach(unimplementedMethods, function(methodName) {
-    this[methodName] = function() {
+    self[methodName] = function() {
       throw {
         name: "MethodNotImplemented",
         message: "Method '" + methodName + "' is not implemented in the TzDate mock"

src/angular.prefix

@@ -21,4 +21,5 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  * THE SOFTWARE.
  */
+'USE STRICT';
 (function(window, document, undefined){

src/apis.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var angularGlobal = {
   'typeOf':function(obj){
     if (obj === null) return $null;

src/directives.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc overview

src/filters.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc overview
@@ -114,7 +116,7 @@ angularFilter.number = function(number, fractionSize){
       pow = Math.pow(10, fractionSize),
       whole = '' + number,
       formatedText = '',
-      i;
+      i, fraction;
 
   if (whole.indexOf('e') > -1) return whole;
 

src/formatters.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc overview

src/jqLite.js

@@ -1,3 +1,5 @@
+'use strict';
+
 //////////////////////////////////
 //JQLite
 //////////////////////////////////

src/jstd-scenario-adapter/Adapter.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * JSTestDriver adapter for angular scenario tests
  *

src/markups.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc overview

src/parser.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var OPERATORS = {
     'null':function(self){return null;},
     'true':function(self){return true;},
@@ -290,11 +292,9 @@ function parser(text, json){
     var token = peek(e1, e2, e3, e4);
     if (token) {
       if (json && !token.json) {
-        index = token.index;
         throwError("is not valid json", token);
       }
       tokens.shift();
-      this.currentToken = token;
       return token;
     }
     return false;

src/sanitizer.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /*
  * HTML Parser By Misko Hevery ([email protected])
  * based on:  HTML Parser By John Resig (ejohn.org)

src/scenario/Application.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Represents the application currently being tested and abstracts usage
  * of iframes or separate windows.

src/scenario/Describe.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * The representation of define blocks. Don't used directly, instead use
  * define() in your tests.

src/scenario/Future.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * A future action in a spec.
  *

src/scenario/ObjectModel.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Maintains an object tree from the runner events.
  *

src/scenario/Runner.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Runner for scenarios
  *

src/scenario/Scenario.js

@@ -1,3 +1,5 @@
+'use strict';
+
 
 /**
  * Setup file for the Scenario.

src/scenario/SpecRunner.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * This class is the "this" of the it/beforeEach/afterEach method.
  * Responsibilities:

src/scenario/angular-bootstrap.js

@@ -1,3 +1,5 @@
+'use strict';
+
 (function(previousOnLoad){
   var prefix = (function(){
     var filename = /(.*\/)angular-bootstrap.js(#(.*))?/;

src/scenario/dsl.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Shared DSL statements that are useful to all scenarios.
  */

src/scenario/matchers.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Matchers for implementing specs. Follows the Jasmine spec conventions.
  */

src/scenario/output/Html.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * User Interface for the Scenario Runner.
  *

src/scenario/output/Json.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Generates JSON output into a context.
  */

src/scenario/output/Object.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Creates a global value $result with the result of the runner.
  */

src/scenario/output/Xml.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Generates XML output into a context.
  */

src/service/cookieStore.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/cookies.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/defer.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/document.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/exceptionHandler.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/hover.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/invalidWidgets.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/location.js

@@ -1,3 +1,5 @@
+'use strict';
+
 var URL_MATCH = /^(file|ftp|http|https):\/\/(\w+:{0,1}\w*@)?([\w\.-]*)(:([0-9]+))?(\/[^\?#]*)?(\?([^#]*))?(#(.*))?$/,
     HASH_MATCH = /^([^\?]*)?(\?([^\?]*))?$/,
     DEFAULT_PORTS = {'http': 80, 'https': 443, 'ftp':21};

src/service/log.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/resource.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/route.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/updateView.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/window.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/xhr.bulk.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/xhr.cache.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/xhr.error.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/service/xhr.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc service

src/validators.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc overview

src/widgets.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * @workInProgress
  * @ngdoc overview