This repository was archived by the owner on Apr 12, 2024. It is now read-only.
turn on EcmaScript5 strict mode #345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome |
|
I wanted to make sure that we have better strict mode coverage, so I enabled the strict mode in the unit tests as well and came across several other issues. nothing major, it will just take time to fix them all. |
|
status update: this is not ready to be merged yet. |
- add 'use strict'; statement to the prefix file - configure closure compiler to use the ES5 strict mode - strip all file-specific strict mode flags after concatination Closes angular#223
the flag must be in all src and test files so that we get the benefit of running in the strict mode even in jstd the following script was used to modify all files: for file in `find src test -name "*.js"`; do echo -e "'use strict';\n" > temp.txt cat $file >> temp.txt mv temp.txt $file done
|
status update: this PR is ready for review now |
|
👍 LGTM |
|
👍 LGTM -> nice work! |
|
[angular.js] IgorMinar pushed 5 new commits to master: http://bit.ly/qxXdvo |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
statement from minified code
Closes #223