docs(minerr): fill in error message descriptions #3430
Conversation
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| @@ -2,3 +2,25 @@ | |||
| @name $injector:cdep | |||
| @fullName Circular Dependency | |||
| @description | |||
|
|
|||
| This error occurs when trying to get a service that depends on itself, either | |||
There was a problem hiding this comment.
This error occurs when the {@link $injector} tries to resolve a dependency that depends upon itself,...
Errors I've documented so far: - `$injector:cdep` - `$injector:itkn` - `$injector:modulerr` - `$injector:nomod` - `$injector:pget` - `$injector:unpr` - `ng:areq` - `ng:cpi` - `ng:cpws` - `ngModel:noass`
|
The PR closed itself. Interesting. Maybe we could add a pre-commit hook to make all PRs self-closing when merged. Probably that's a bad idea. Really what we need is a rebase button. |
|
If you put 'closes #1234' in your commit msg then github automatically close the relevant PR when the commit hits master. |
|
I get that, but I didn't put that in my commit msg. It looks like Igor did it for me. |
|
it closed because I added |
Errors I've documented so far:
$injector:cdep$injector:itkn$injector:modulerr$injector:nomod$injector:pget$injector:unprng:areqng:cping:cpwsngModel:noassThis is an incomplete list and should be considered a WIP until the team has gone through the error doc spreadsheet.