This repository was archived by the owner on Apr 12, 2024. It is now read-only.
First stage for adding goog.provide/require style dependencies. #1965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhevery how does this LGTY? most of the requires make no sense, they just artificially ensure that the current file order is preserved. I think that biting the bullet and manually figuring out the dependencies for real is a better way to add the code dependency info into the codebase. -1 |
Add .pyc files to .gitignore. Also specify that only the top level build directory is to be ignored. (In pref for closure-library which has a build subdirectory that we don't want to ignore.)
Add the minimal part of closure-library to pull in closurebuilder.py. closurebuilder.py depends on a few other .js files as well as goog.base. These are included as well. The directory tree mimics that of the closure-library to keep things easy to figure out.
Add goog.provide / goog.require style dependencies and use
closurebuilder.py to concat the script together.
The goal for this commit is:
- to have the smallest diff for the generated
build/angular.js.
- Be a fairly mechanical change to make a review easier since it
touched a whole bunch of files.
|
as discussed we are going to do this in a different way once #1951 lands |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add goog.provide / goog.require style dependencies and use
closurebuilder.py to concat the script together.
The goal for these commits is:
build/angular.js.
reviewing.