Closure annotations - STALE! #1951
Conversation
|
btw use |
| bind: function bindFn(element, type, fn){ | ||
| var events = JQLiteExpandoStore(element, 'events'), | ||
| handle = JQLiteExpandoStore(element, 'handle'); | ||
| removeData: /** @type {function():!JQLite} */(JQLiteRemoveData), |
There was a problem hiding this comment.
@IgorMinar - why are all these functions wrapped in parentheses?
There was a problem hiding this comment.
because I'm doing a cast here. all of these functions take one extra argument (element) which is curried before the function is exposed as public api. This meta-programming confuses the closure compiler, so I had to resort to this cast.
custom compiled compiler at r4796bc81
currently only for angular.js, more to come
This change resolves all warnings found by the closure compiler when verbose mode is turned on and all the other flags remain at defaults. Part of this commit contains code contributed by Ben McCann via PR angular#1710.
|
For what it's worth, we're very interested to be able to fit Angular.js into our existing Closure-based toolchain as well. |
|
would really love to see this make its way in! |
|
@benmccann do you know what the status is for getting closure compiler to work with advanced optimizations? We're using angular-1.4.4 without advanced optimizations which seems to work ok, but would like advanced optimizations |
|
@IgorMinar is there anything we can do to help get this in? perhaps it would be an easier change to submit if we broke it up into smaller changes? or do you still plan on merging this? |
|
I hit a hiccup with our end-to-end tests failing due to unknown reasons after we created the build in this way and I didn't have time to look into it since. I plan on resurrecting this PR in the next few days. |
|
The Closure compiler is now at a newer version than the one used in this CL: |
|
it's very unlikely that we'll merge this in at this point. when considering the change required vs benefits to people using angular it doesn't make sense. I know that there is a few people that would welcome this change but it's a small minority and for those our externs solution works "well enough" (I know it's not ideal). closing. |
ready for review.. only minor polish remains
this PR adds and corrects closure annotations and turns on compiler flags so that we get basic type checking during compilation of angular.js