-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs(guide/Conceptual Overview): use exchangeratesapi.io #16808
Conversation
As fixer.io introduced an API key and thus a limitation of calls (see https://github.com/fixerAPI/fixer#readme ), change https://api.fixer.io to https://api.exchangeratesapi.io instead, which is "designed and tested to handle thousands of request per second" and has "built in Fixer.io compatibility so you can keep all the libraries you already like and use daily" (from https://api.exchangeratesapi.io ). The idea is from fixerAPI/fixer#107 fixes angular#16807
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! (the individual CLA) |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
As fixer.io introduced an API key and thus a limitation of calls (see https://github.com/fixerAPI/fixer#readme ), change https://api.fixer.io to https://api.exchangeratesapi.io instead, which is "designed and tested to handle thousands of request per second" and has "built in Fixer.io compatibility so you can keep all the libraries you already like and use daily" (from https://api.exchangeratesapi.io ). The idea is from fixerAPI/fixer#107 fixes #16807 Closes #16808
docs(guide/Conceptual Overview): use another exchange rate API
As fixer.io introduced an API key and thus a limitation of calls (see https://github.com/fixerAPI/fixer#readme), change https://api.fixer.io to https://api.exchangeratesapi.io instead, which is "designed and tested to handle thousands of request per second" and has "built in Fixer.io compatibility so you can keep all the libraries you already like and use daily" (from https://api.exchangeratesapi.io).
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
The finance3.js service module in the Conceptual Overview section of the Angular documentation does not work without an API key. See #16807
What is the new behavior (if this is a feature change)?
Another another currency converter API is used instead (namely the MIT licensed https://api.exchangeratesapi.io), which does not need an API key and which is "designed and tested to handle thousands of request per second"
and has "built in Fixer.io compatibility so you can keep all the libraries you already like and use daily" (from https://api.exchangeratesapi.io). Idea is from #16137
Does this PR introduce a breaking change?
No.
Other information:
The Idea is from fixerAPI/fixer#107
fixes #16807