This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fixer.io API needs to be updated with a new endpoint requiring an access key #16807
Comments
bkiselka
added a commit
to bkiselka/angular.js
that referenced
this issue
Jan 4, 2019
As fixer.io introduced an API key and thus a limitation of calls (see https://github.com/fixerAPI/fixer#readme ), change https://api.fixer.io to https://api.exchangeratesapi.io instead, which is "designed and tested to handle thousands of request per second" and has "built in Fixer.io compatibility so you can keep all the libraries you already like and use daily" (from https://api.exchangeratesapi.io ). The idea is from fixerAPI/fixer#107 fixes angular#16807
gkalpak
pushed a commit
that referenced
this issue
Jan 7, 2019
As fixer.io introduced an API key and thus a limitation of calls (see https://github.com/fixerAPI/fixer#readme ), change https://api.fixer.io to https://api.exchangeratesapi.io instead, which is "designed and tested to handle thousands of request per second" and has "built in Fixer.io compatibility so you can keep all the libraries you already like and use daily" (from https://api.exchangeratesapi.io ). The idea is from fixerAPI/fixer#107 fixes #16807 Closes #16808
|
Thank you for addressing. |
This was referenced Jan 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm submitting a ...
Current behavior:
Please treat this bug report as a recurrence of #16130.
The fixer.io API endpoint used in the finance3.js service module in the Conceptual Overview section of the Angular documentation is outdated. Here is the supporting readme note:
https://github.com/fixerAPI/fixer#readme
Please ensure that the endpoint is changed to make sure that the example is functional. If obtaining an access key for the documentation example is not feasible, please consider going with another currency converter API.
Expected / new behavior:
https://api.fixer.io/latest?base=USD&symbols=USD,EUR,CNY
Minimal reproduction of the problem with instructions:
AngularJS version: 1.x.y
1.7.X-snapshot
Browser: [all | Chrome XX | Firefox XX | Edge XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView | Opera XX ]
Anything else:
GET https://api.fixer.io/latest?base=USD&symbols=USD,EUR,CNY 404
The text was updated successfully, but these errors were encountered: