Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

outdated example with Yahoo Finance API #16130

Closed
1 of 3 tasks
elenaparaschiv opened this issue Jul 25, 2017 · 10 comments · Fixed by angular-indonesia/angular.js#57 or GulajavaMinistudio/angular.js#53
Closed
1 of 3 tasks

Comments

@elenaparaschiv
Copy link

elenaparaschiv commented Jul 25, 2017

I'm submitting a ...

  • bug report
  • feature request
  • other (Please do not submit support requests here (see above))

Current behavior:

In the Conceptual Overview Section > Accessing the backend> in finance3.js the example with Yahoo Finance API is outdated. Currently the Yahoo Finance API is broken.

Expected / new behavior:

In the section Conceptual Overview> Accessing the backend > finance3.js:
I suggest adding a new example that is not outdated or soon to be outdated. This will keep the documentation up to date and increase its readability.

Minimal reproduction of the problem with instructions:

Angular version: 1.x.y

Browser: [all | Chrome XX | Firefox XX | Edge XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Anything else:

One example that could replace the Yahoo Finance API is the API made by https://docs.openexchangerates.org/

Other suggestions:
https://1forge.com/forex-data-api
http://www.financialcontent.com/support/documentation/json_quote_api.php

@gkalpak
Copy link
Member

gkalpak commented Jul 26, 2017

I don't see the example being broken as you suggested. But if there is a solid alternative, we could consider moving the example to another API. (PRs welcome 😃)

@jeserkin
Copy link

Not sure how Yahoo is related to AngularJS.

@gkalpak
Copy link
Member

gkalpak commented Jul 28, 2017

Not sure what you mean. Yahoo is not related to AngularJS (except that we use the Yahoo Finance API in one of our examples).

@elenaparaschiv
Copy link
Author

elenaparaschiv commented Jul 28, 2017

@gkalpak Yes. I am suggesting the Yahoo Finance API is not currently available. When I was reading the documentation for angular : section on Conceptual Overview > Accessing the backend, the example there is using the Yahoo Finance API.
I wanted to check for the Yahoo Finance API to see the docs of how this API is added. And I could not find it. I was thinking it would be better to add another API as an example in this section that has documentation at the current moment. I suggested https://docs.openexchangerates.org/ as well as a few others in my initial post.

@frederikprijck
Copy link
Contributor

I don't think the docs for the Yahoo API are necessary in order to understand what's happening in the AngularJS docs, but I guess it wouldn't hurt updating the samples to an API which does have some docs.

@gkalpak
Copy link
Member

gkalpak commented Jul 28, 2017

OK, so in fact we are not using the Yahoo Finance API. We are using YQL (which is just a query language) to query data form datatables.org. You can find docs in these links.

And, as already mentioned, we could consider moving to an alternative API if it made the example simpler or better in some way (PRs welcome).

@andypotts
Copy link
Contributor

I'd like to update the example if no one else is already doing it?

@elenaparaschiv
Copy link
Author

That would be great @andypotts

@andypotts
Copy link
Contributor

@elenaparaschiv @gkalpak In that PR I used the http://fixer.io/ API and was able to create a simpler solution. Let me know if you want me to change it to use a different API.

@elenaparaschiv
Copy link
Author

Nice work @andypotts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.