Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs:(attrs) extended @element ngDisabled #16775

Closed
wants to merge 1 commit into from
Closed

docs:(attrs) extended @element ngDisabled #16775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ng/directive/attrs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
</file>
</example>
*
* @element INPUT
* @element INPUT, BUTTON, SELECT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically, it can go on any element, but I guess it makes sense to only recommend it for form controls.
What about textarea?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u're right, there might be some elements missing. At this moment it is just input and i kinda hatet, my idea shows me some errors, so i just added what i need. Due to the build fail, I don't think, that i will improve this pull request, or make any other request. So IF you want to improve the documentation, you could just add the form elements to the element tag and i will be pleased

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can still add textarea in a new commit, the build failures are unrelated to your changes

* @param {expression} ngDisabled If the {@link guide/expression expression} is truthy,
* then the `disabled` attribute will be set on the element
*/
Expand Down