-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs:(attrs) extended @element ngDisabled #16775
Conversation
Using Intellij's IDE will cause this not to mark ng-disabled on buttons or selects as not allowed attribute
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
@@ -181,7 +181,7 @@ | |||
</file> | |||
</example> | |||
* | |||
* @element INPUT | |||
* @element INPUT, BUTTON, SELECT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theoretically, it can go on any element, but I guess it makes sense to only recommend it for form controls.
What about textarea
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
u're right, there might be some elements missing. At this moment it is just input and i kinda hatet, my idea shows me some errors, so i just added what i need. Due to the build fail, I don't think, that i will improve this pull request, or make any other request. So IF you want to improve the documentation, you could just add the form elements to the element tag and i will be pleased
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can still add textarea in a new commit, the build failures are unrelated to your changes
Disabled can be set on many different elements, and might also be used on custom controls, so it's better to remove the restriction completely Closes #16775
Using Intellij's IDE will cause this not to mark ng-disabled on buttons or selects as not allowed attribute
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
Intellij will mark ng-disabled as not allowed attribute on some form elements
What is the new behavior (if this is a feature change)?
ng-disabled is now also allowed on buttons and selects
Does this PR introduce a breaking change?
nope
Please check if the PR fulfills these requirements
Other information:
none