Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

<docs>: Add breaking change warning #16667

Closed
wants to merge 1 commit into from
Closed

<docs>: Add breaking change warning #16667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@
([7cf4a2](https://github.com/angular/angular.js/commit/7cf4a2933cb017e45b0c97b0a836cbbd905ee31a),
[#16641](https://github.com/angular/angular.js/issues/16641),
[#16642](https://github.com/angular/angular.js/issues/16642))
- **ngAria:** do not scroll when pressing spacebar on custom buttons
([3a517c](https://github.com/angular/angular.js/commit/3a517c25f677294a7a9eca1660654a3edcc9e103),
[#14665](https://github.com/angular/angular.js/issues/14665),
[#16604](https://github.com/angular/angular.js/issues/16604))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking changes can be "added" to the log, but we should still keep the original commits under the Bug Fixes heading.



## New Features
Expand Down Expand Up @@ -86,6 +82,11 @@
[#14166](https://github.com/angular/angular.js/issues/14166),
[#16613](https://github.com/angular/angular.js/issues/16613))

## Breaking Changes
- **ngAria:** do not scroll when pressing spacebar on custom buttons. This makes the space key stop working for inputs inside of ngClick elements (see [#16664](#16664))
([3a517c](https://github.com/angular/angular.js/commit/3a517c25f677294a7a9eca1660654a3edcc9e103),
[#14665](https://github.com/angular/angular.js/issues/14665),
[#16604](https://github.com/angular/angular.js/issues/16604))

<a name="1.7.2"></a>
# 1.7.2 extreme-compatiplication (2018-06-12)
Expand Down