Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

<docs>: Add breaking change warning #16667

Closed
wants to merge 1 commit into from
Closed

Conversation

hoeni
Copy link

@hoeni hoeni commented Aug 17, 2018

add warning about changed space key in inputs

#16664

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?
No. It warns about an existing breaking change :-)

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

add warning about changed space key in inputs

angular#16664
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@hoeni
Copy link
Author

hoeni commented Aug 17, 2018

I signed it.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

- **ngAria:** do not scroll when pressing spacebar on custom buttons
([3a517c](https://github.com/angular/angular.js/commit/3a517c25f677294a7a9eca1660654a3edcc9e103),
[#14665](https://github.com/angular/angular.js/issues/14665),
[#16604](https://github.com/angular/angular.js/issues/16604))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking changes can be "added" to the log, but we should still keep the original commits under the Bug Fixes heading.

@gkalpak
Copy link
Member

gkalpak commented Aug 20, 2018

We shouldn't land this imo. We should either fix the breakage (see #16664 (comment)) or revert the change.

@Narretz
Copy link
Contributor

Narretz commented Sep 6, 2018

We've changed the behavior so that the default is not prevented when click is triggered from an interactive element. This will land in 1.7.4. If you have already used ng-aria-ignore or ng-prop-click, you should keep it this way, because it's better for aria overall.

@Narretz Narretz closed this Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants