-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
add warning about changed space key in inputs angular#16664
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
- **ngAria:** do not scroll when pressing spacebar on custom buttons | ||
([3a517c](https://github.com/angular/angular.js/commit/3a517c25f677294a7a9eca1660654a3edcc9e103), | ||
[#14665](https://github.com/angular/angular.js/issues/14665), | ||
[#16604](https://github.com/angular/angular.js/issues/16604)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking changes can be "added" to the log, but we should still keep the original commits under the Bug Fixes heading.
We shouldn't land this imo. We should either fix the breakage (see #16664 (comment)) or revert the change. |
We've changed the behavior so that the default is not prevented when click is triggered from an interactive element. This will land in 1.7.4. If you have already used ng-aria-ignore or ng-prop-click, you should keep it this way, because it's better for aria overall. |
add warning about changed space key in inputs
#16664
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
No. It warns about an existing breaking change :-)
Please check if the PR fulfills these requirements
Other information: