Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(karma): use dots reporter by default #16167

Merged
merged 1 commit into from
Aug 11, 2017
Merged

chore(karma): use dots reporter by default #16167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion karma-shared.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module.exports = function(config, specificOptions) {
browserDisconnectTimeout: 10000,
browserDisconnectTolerance: 2,
browserNoActivityTimeout: 30000,
reporters: ['spec'],
reporters: ['dots'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does spec look better on CI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because it doesn't generate a dot for each test, so the test results are easier to scroll through - I changed that a while ago, but accidentially added it locally too. Locally, dots is better because you often follow the progress while it's testing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, were do we configure Travis to use the spec reporter? 😕

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cl argument here:

angular.js/scripts/travis/build.sh

Line 28 in 5b31b37

grunt test:unit --browsers="$BROWSERS" --reporters=spec

specReporter: {
maxLogLines: 5, // limit number of lines logged per test
suppressErrorSummary: true, // do not print error summary
Expand Down