This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(karma): use dots reporter by default #16167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dots is nicer for local testing, as you usually don't run a ton of test suites, and it's also more readable if you skip many tests (i.e. run isolated tests)
gkalpak
reviewed
Aug 11, 2017
| @@ -10,7 +10,7 @@ module.exports = function(config, specificOptions) { | |||
| browserDisconnectTimeout: 10000, | |||
| browserDisconnectTolerance: 2, | |||
| browserNoActivityTimeout: 30000, | |||
| reporters: ['spec'], | |||
| reporters: ['dots'], | |||
There was a problem hiding this comment.
Yes, because it doesn't generate a dot for each test, so the test results are easier to scroll through - I changed that a while ago, but accidentially added it locally too. Locally, dots is better because you often follow the progress while it's testing
There was a problem hiding this comment.
So, were do we configure Travis to use the spec reporter? 😕
There was a problem hiding this comment.
cl argument here:
angular.js/scripts/travis/build.sh
Line 28 in 5b31b37
gkalpak
approved these changes
Aug 11, 2017
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Aug 18, 2017
dots is nicer for local testing, as you usually don't run a ton of test suites, and the progress visualization is more important . It's also more readable if you skip many tests (i.e. run isolated tests) Closes angular#16167
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dots is nicer for local testing, as you usually don't run a
ton of test suites, and it's also more readable if you skip
many tests (i.e. run isolated tests)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: