This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test($parse): add one-time/interceptor tests #16043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
one-time-int-tests
branch
2 times, most recently
from
5fb7856 to
220537c
Compare
test/ng/parseSpec.js
Outdated
| @@ -3321,6 +3321,32 @@ describe('parser', function() { | |||
| scope.$digest(); | |||
| expect(called).toBe(true); | |||
| })); | |||
|
|
|||
| it('should not effect when a one-time binding becomes stable', inject(function($parse) { | |||
There was a problem hiding this comment.
effect -> affect, I think
There was a problem hiding this comment.
Thank you for correcting my engrish :)
petebacondarwin
approved these changes
Jun 12, 2017
jbedard
force-pushed
the
one-time-int-tests
branch
from
220537c to
eb3efe1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that 189461f changed this a little - previously the second test failed for two reasons
identityinterceptor would throw an infdig because the literal recreated each digest was being watchedisDefinedto determine when the one time is "done" which is unlike the one-time watch delegate that checks all the values in the literal, so the interceptor thought the "one-time" was done right away for literalsI think both of these changes are correct and want to make sure we don't revert them. This should probably only go into 1.7 since this change will probably be reverted in 1.6.