Revert "fix($parse): standardize one-time literal vs non-literal and interceptors"

[jbedard]

Reverts 60394a9 to fix #15905 in 1.6. Currently plan is to NOT revert in 1.7.

Fixes #15905

[gkalpak]

LGTM, but can you create an issue on the 1.7.0 milestone for documenting the breaking change on 17.x (I am not sure what exactly we have broken, but I understand we have broken some usecase).

[jbedard]

Created #15960

[jbedard]

Note that fixing #15964 should actually fix the issue in 1.6, so it might still be possible to fix this in 1.6 without reverting anything...

[Narretz]

What's the status of this now that #15964 has been fixed?

[jbedard]

#15964 fixed filters, #16018 does the same for interceptors (like the one in ng-class). I'm leaning toward still reverting the ng-class part of 189461f in 1.6 just to avoid unexpected changes in 1.6 (no longer deep watching one-time bindings in ng-class), but that's debatable...

[Narretz]

This looks like the last PR needed to get 1.6.5 out of the door, ist thart right?

[jbedard]

Note that #15905 was properly fixed in 1.6, so this revert now only restores the "deep watch of one-time bindings in ng-class". I keep trying to find a way revert that without reverting the parse.js changes, but that isn't proving easy. So yeah I think we should just revert this in 1.6. Feel free to merge if you agree...

[jbedard]

Ok now that I've found #16059 we have to do this revert (or #16015!) in 1.6...

[Narretz]

So what you are saying is, to restore " "deep watch of one-time bindings in ng-class" we can either merge

• this PR (Revert "fix($parse): standardize one-time literal vs non-literal and interceptors" #15958)

or both of

• fix($parse): respect the interceptor.$stateful flag #16015
• perf($rootScope): do not mark $watchCollectionInterceptor as $stateful #16009

(their respective 1.6 versions)

I assume by reverting we err on the safe side? Because we want to remove the deep watch in master anyway

[jbedard]

It's actually

• fix($parse): respect the interceptor.$stateful flag #16015 (which now has 2 commits)

or both of

• Revert "fix($parse): standardize one-time literal vs non-literal and interceptors" #15958 (this pr)
• fix($parse): do not shallow-watch inputs to one-time intercepted expressions #16059

While I really don't like reverting things, we should probably go the revert route for 1.6... If you're ok with #16059 in 1.6 I can merge those 2 this weekend.

[Narretz]

LGTM. Please revert and merge #16059 too