This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(jenkins): get rid of Opera from the Jenkins build script, it doesn't work #15691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't work The Opera launcher hasn't been installed for ages but until Karma 1.4.0 the error of Opera not being able to start was ignored. Karma has fixed the bug and now Jenkins is failing.
We don't support Opera officially anymore (it's sort-of supported via being based on Blink) so its mentions in the docs has now been removed. We also don't have the Opera launcher installed so the advise to use it just wouldn't work anyway.
|
Should the first commit be of the |
|
You know there is no |
|
There is in the labels! 😞 |
|
¯\_(ツ)_/¯ |
gkalpak
pushed a commit
that referenced
this pull request
Feb 9, 2017
The Opera launcher hasn't been installed for ages, but until Karma 1.4.0 the error of Opera not being able to start was ignored. Karma has fixed the bug and now Jenkins is failing. This commit also removes Opera/Opera launcher mentions from the docs. We don't support Opera officially anymore (it's sort-of supported via being based on Blink). Closes #15691
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
The Opera launcher hasn't been installed for ages, but until Karma 1.4.0 the error of Opera not being able to start was ignored. Karma has fixed the bug and now Jenkins is failing. This commit also removes Opera/Opera launcher mentions from the docs. We don't support Opera officially anymore (it's sort-of supported via being based on Blink). Closes angular#15691
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix
What is the current behavior? (You can also link to an open issue here)
Jenkins fails because the Opera Karma launcher is missing.
What is the new behavior (if this is a feature change)?
Opera is not tried to be launched.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Other information:
Another commit removes Opera mentions from source as we no longer support it officially.