Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 2c7400e

Browse files
mgolgkalpak
authored andcommitted
chore(jenkins): get rid of Opera from the Jenkins build script
The Opera launcher hasn't been installed for ages, but until Karma 1.4.0 the error of Opera not being able to start was ignored. Karma has fixed the bug and now Jenkins is failing. This commit also removes Opera/Opera launcher mentions from the docs. We don't support Opera officially anymore (it's sort-of supported via being based on Blink). Closes #15691
1 parent 2af2607 commit 2c7400e

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

docs/content/misc/contribute.ngdoc

+3-3
Original file line numberDiff line numberDiff line change
@@ -140,13 +140,13 @@ tests once on Chrome run:
140140
grunt test:unit
141141
```
142142

143-
To run the tests on other browsers (Chrome, ChromeCanary, Firefox, Opera and Safari are pre-configured) use:
143+
To run the tests on other browsers (Chrome, ChromeCanary, Firefox and Safari are pre-configured) use:
144144

145145
```shell
146-
grunt test:unit --browsers=Opera,Firefox
146+
grunt test:unit --browsers=Chrome,Firefox
147147
```
148148

149-
Note there should be _no spaces between browsers_. `Opera, Firefox` is INVALID.
149+
Note there should be _no spaces between browsers_. `Chrome, Firefox` is INVALID.
150150

151151
During development, however, it's more productive to continuously run unit tests every time the source or test files
152152
change. To execute tests in this mode run:

scripts/jenkins/build.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ set -xe
1212
# This is the default set of browsers to use on the CI server unless overridden via env variable
1313
if [[ -z "$BROWSERS" ]]
1414
then
15-
BROWSERS="Chrome,Firefox,Opera,/Users/jenkins/bin/safari.sh"
15+
BROWSERS="Chrome,Firefox,/Users/jenkins/bin/safari.sh"
1616
fi
1717

1818
# CLEAN #

src/ng/browser.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,8 @@ function Browser(window, document, $log, $sniffer) {
255255
self.onUrlChange = function(callback) {
256256
// TODO(vojta): refactor to use node's syntax for events
257257
if (!urlChangeInit) {
258-
// We listen on both (hashchange/popstate) when available, as some browsers (e.g. Opera)
259-
// don't fire popstate when user change the address bar and don't fire hashchange when url
258+
// We listen on both (hashchange/popstate) when available, as some browsers don't
259+
// fire popstate when user changes the address bar and don't fire hashchange when url
260260
// changed by push/replaceState
261261

262262
// html5 history api - popstate event

src/ng/urlUtils.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ var baseUrlParsingNode;
2020
* URL will be resolved into an absolute URL in the context of the application document.
2121
* Parsing means that the anchor node's host, hostname, protocol, port, pathname and related
2222
* properties are all populated to reflect the normalized URL. This approach has wide
23-
* compatibility - Safari 1+, Mozilla 1+, Opera 7+,e etc. See
23+
* compatibility - Safari 1+, Mozilla 1+ etc. See
2424
* http://www.aptana.com/reference/html/api/HTMLAnchorElement.html
2525
*
2626
* Implementation Notes for IE

test/ngMock/angular-mocksSpec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -923,7 +923,7 @@ describe('ngMock', function() {
923923
}));
924924

925925
describe('error stack trace when called outside of spec context', function() {
926-
// - Chrome, Firefox, Edge, Opera give us the stack trace as soon as an Error is created
926+
// - Chrome, Firefox, Edge give us the stack trace as soon as an Error is created
927927
// - IE10+, PhantomJS give us the stack trace only once the error is thrown
928928
// - IE9 does not provide stack traces
929929
var stackTraceSupported = (function() {

0 commit comments

Comments
 (0)