Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(filter): Don't throw key.charAt is not a function when object's keys are not of type string. #15660

Closed
wants to merge 2 commits into from
Closed

fix(filter): Don't throw key.charAt is not a function when object's keys are not of type string. #15660

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bcc73f
fix(filter): Don't throw `key.charAt is not a function` when object's…
frederikprijck Feb 1, 2017
b84bcba
fixup! fix(filter): Don't throw `key.charAt is not a function` when o…
frederikprijck Feb 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ng/filter/filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ function deepCompare(actual, expected, comparator, anyPropertyKey, matchAgainstA
var key;
if (matchAgainstAnyProp) {
for (key in actual) {
if ((key.charAt(0) !== '$') && deepCompare(actual[key], expected, comparator, anyPropertyKey, true)) {
if (key.charAt && (key.charAt(0) !== '$') && deepCompare(actual[key], expected, comparator, anyPropertyKey, true)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment (and maybe a link to the issue) for context. Something like:

Under certain, extreme circumstances, key may not be a string. See ...`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comment.

return true;
}
}
Expand Down