This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(filter): Don't throw key.charAt is not a function when object's keys are not of type string.
#15660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
changed the title
key.charAt is not a function when object's keys are not of type string.key.charAt is not a function when object's keys are not of type string.
… keys are not of type `string`. Previously, when an object has keys which are not of type string, the `filter` would throw an exception for trying to call `charAt`, which is not defined on a none-string type. This commit checks whether `charAt` is defined before calling it. Closes #15644
|
Can you please add a test for this? |
|
I am afraid it is not possible (as discussed in #15644) 😁 Unless we messed with the |
gkalpak
suggested changes
Feb 1, 2017
src/ng/filter/filter.js
Outdated
| @@ -226,7 +226,7 @@ function deepCompare(actual, expected, comparator, anyPropertyKey, matchAgainstA | |||
| var key; | |||
| if (matchAgainstAnyProp) { | |||
| for (key in actual) { | |||
| if ((key.charAt(0) !== '$') && deepCompare(actual[key], expected, comparator, anyPropertyKey, true)) { | |||
| if (key.charAt && (key.charAt(0) !== '$') && deepCompare(actual[key], expected, comparator, anyPropertyKey, true)) { | |||
There was a problem hiding this comment.
Add a comment (and maybe a link to the issue) for context. Something like:
Under certain, extreme circumstances,
keymay not be a string. See ...`
There was a problem hiding this comment.
I've added some comment.
…bject's keys are not of type `string`.
gkalpak
approved these changes
Feb 1, 2017
|
LGTM if it LGT @Narretz 😃 |
|
LGTM |
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Previously, when an object has keys which are not of type string, `filterFilter` would throw an exception for trying to call `key.charAt()`, which is a string method. This commit checks whether `charAt` is defined before calling it. Fixes angular#15644 Closes angular#15660
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
When an object has keys which are not of type string, the
filterwould throw an exception for trying to callcharAt, which is not defined on a none-string type.#15644
What is the new behavior (if this is a feature change)?
This commit checks whether
charAtis defined before calling it.Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: