Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Set request timeout response status #15621

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/ng/httpBackend.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,14 @@ function createHttpBackend($browser, createXhr, $browserDefer, callbacks, rawDoc
completeRequest(callback, -1, null, null, '');
};

var requestTimeout = function() {
// Set standard request timeout status code: 408
completeRequest(callback, 408, null, null, '');
};

xhr.onerror = requestError;
xhr.onabort = requestError;
xhr.ontimeout = requestError;
xhr.ontimeout = requestTimeout;

forEach(eventHandlers, function(value, key) {
xhr.addEventListener(key, value);
Expand Down
2 changes: 1 addition & 1 deletion test/ng/httpBackendSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ describe('$httpBackend', function() {

it('should complete the request on timeout', function() {
callback.and.callFake(function(status, response, headers, statusText) {
expect(status).toBe(-1);
expect(status).toBe(408);
expect(response).toBe(null);
expect(headers).toBe(null);
expect(statusText).toBe('');
Expand Down