Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Set request timeout response status #15621

Closed
wants to merge 2 commits into from
Closed

Set request timeout response status #15621

wants to merge 2 commits into from

Conversation

tipycalFlow
Copy link

@tipycalFlow tipycalFlow commented Jan 18, 2017

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Returns status 408 in case of xhr timeout

What is the current behavior? (You can also link to an open issue here)
Status returned is -1 which does not help differentiate from other requests returning empty response.

What is the new behavior (if this is a feature change)?
Status returned (408) is standard HTTP response code for request timeout.

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

Other information:

@gkalpak
Copy link
Member

gkalpak commented Jan 18, 2017

Thx for the PR, but the current behavior is intended (see #15380 (comment) for more info).

@gkalpak gkalpak closed this Jan 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants