This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(jqLite): silently ignore after() if element has no parent
#15475
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the element was always assumed to have a parent and an error was thrown when that was not the case. This commit makes jqLite consistent with jQuery, which silently ignores a call on elements that do not have a parent. Fixes angular#15331 Closes angular#15367
Narretz
suggested changes
Dec 8, 2016
|
|
||
| it('should not throw when the element has no parent', function() { | ||
| var span = jqLite('<span></span>'); | ||
| expect(function() { span.after('abc'); }).not.toThrow(); |
There was a problem hiding this comment.
Can you add an expect that the span is still the span?
There was a problem hiding this comment.
The test is now failing :o is it because toJqEqual is wrapped in jqlite?
There was a problem hiding this comment.
😱 It passed locally (on Chrome). IEs seems to have a hard time. I'll take a look.
There was a problem hiding this comment.
Checking DOM Nodes for deep equality isn't an intended usecase apparenty 😃
I changed the expectations.
Narretz
approved these changes
Dec 8, 2016
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Previously, the element was always assumed to have a parent and an error was thrown when that was not the case. This commit makes jqLite consistent with jQuery, which silently ignores a call on elements that do not have a parent. Fixes angular#15331 Closes angular#15367 Closes angular#15475
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix.
What is the current behavior? (You can also link to an open issue here)
The element was always assumed to have a parent and an error was thrown when that was not the case.
What is the new behavior (if this is a feature change)?
jqLite is now consistent with jQuery, which silently ignores a call on elements that do not have a parent.
Does this PR introduce a breaking change?
No. (This change only affects already broken code, that would otherwise throw an error.)
Please check if the PR fulfills these requirements
Docs have been added / updated (for bug fixes / features)Other information:
Fixes #15331
Closes #15367