This repository was archived by the owner on Apr 12, 2024. It is now read-only.
[fix] #15331 Guard against no parent #15367
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx @adambuczynski! Could you add a test and make sure the commit message follows the guidelines. |
|
@gkalpak sorry I don't have the time to do this now, I'm going on leave for 4 weeks 🌴 . It's a trivial fix, maybe someone else can pick up the task to make a test for it, or just merge without test (as there was no test around this functionality to begin with). |
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this pull request
Dec 8, 2016
Previously, the element was always assumed to have a parent and an error was thrown when that was not the case. This commit makes jqLite consistent with jQuery, which silently ignores a call on elements that do not have a parent. Fixes angular#15331 Closes angular#15367
3 tasks
|
Np, @adamreisnz. I'll take care of it. Have fun 🏂 |
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Previously, the element was always assumed to have a parent and an error was thrown when that was not the case. This commit makes jqLite consistent with jQuery, which silently ignores a call on elements that do not have a parent. Fixes angular#15331 Closes angular#15367 Closes angular#15475
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #15331
This patch silently ignores the after operation if the element does not have a parent node, following the implementation in jQuery.