Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(input[radio]): use non-strict comparison for checkedness #15289

Merged
merged 1 commit into from
Oct 18, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/ng/directive/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -1753,7 +1753,9 @@ function radioInputType(scope, element, attr, ctrl) {

ctrl.$render = function() {
var value = attr.value;
element[0].checked = (value === ctrl.$viewValue);
// We generally use strict comparison. This is behavior we cannot change without a BC.
// eslint-disable-next-line eqeqeq
element[0].checked = (value == ctrl.$viewValue);
};

attr.$observe('value', ctrl.$render);
Expand Down
11 changes: 11 additions & 0 deletions test/ng/directive/inputSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -3871,6 +3871,17 @@ describe('input', function() {
});


it('should use non-strict comparison between model and value', function() {
$rootScope.selected = false;
var inputElm = helper.compileInput('<input type="radio" ng-model="selected" ng-value="false">' +
'<input type="radio" ng-model="selected" ng-value="\'\'">' +
'<input type="radio" ng-model="selected" ng-value="0">');

expect(inputElm[0].checked).toBe(true);
expect(inputElm[1].checked).toBe(true);
expect(inputElm[2].checked).toBe(true);
});

it('should watch the expression', function() {
var inputElm = helper.compileInput('<input type="radio" ng-model="selected" ng-value="value">');

Expand Down