This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(input[radio]): use non-strict comparison for checkedness #15289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced during the switch to ESLint, but it is a breaking change.
Narretz
force-pushed
the
fix-radio-strict-15
branch
from
b315563 to
5f89bbd
Compare
|
Can you mention the commit that introduced the regression in this PR or better yet in the commit message? Other than that LGTM |
|
So, it didn't make it into master, but it did make it into 1.5.x. |
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
This was introduced during the switch to ESLint (b1bc251#diff-c244afd8def7f268b16ee91a0341c4b2R1691), but it is a breaking change. In master, we made an exception for this comparison when we introduced jshint eqeqeq (which was not backported to 1.5.x). PR (angular#15289)
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
This was introduced during the switch to ESLint (b1bc251#diff-c244afd8def7f268b16ee91a0341c4b2R1691), but it is a breaking change. In master, we made an exception for this comparison when we introduced jshint eqeqeq (which was not backported to 1.5.x). PR (angular#15289)
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
This was introduced during the switch to ESLint (b1bc251#diff-c244afd8def7f268b16ee91a0341c4b2R1691), but it is a breaking change. In master, we made an exception for this comparison when we introduced jshint eqeqeq (which was not backported to 1.5.x). PR (angular#15289)
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
This was introduced during the switch to ESLint (b1bc251#diff-c244afd8def7f268b16ee91a0341c4b2R1691), but it is a breaking change. In master, we made an exception for this comparison when we introduced jshint eqeqeq (which was not backported to 1.5.x). PR (angular#15289)
petebacondarwin
pushed a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 21, 2016
This was introduced during the switch to ESLint (b1bc251#diff-c244afd8def7f268b16ee91a0341c4b2R1691), but it is a breaking change. In master, we made an exception for this comparison when we introduced jshint eqeqeq (which was not backported to 1.5.x). PR (angular#15289)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Reverting a Breaking Change
What is the current behavior? (You can also link to an open issue here)
Checkedness is determined by comparing $viewValue and value strictly.
What is the new behavior (if this is a feature change)?
Checkedness is determined by comparing $viewValue and value non-strictly.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
[ ] Docs have been added / updated (for bug fixes / features)Other information:
This was introduced during the switch to ESLint, but it is a breaking change.