This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor(ngMock): extract browserTrigger from ngScenario #14718
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to fix the jshint failures. Also, should this only go in master or 1.5.x as well? |
|
I'd say master only. If someone uses ngScenario with browserTrigger in 1.5, and and doesn't use ngMock at the same time, it would be a BC. Should we completely remove ngScenario at the same time? |
Narretz
force-pushed
the
refactor-browserTrigger
branch
from
4c814f4 to
6b6bde3
Compare
|
I agree we should remove ngScenario in 1.6. It has been deprecated for some time and I even tried to get some people who claim to use it to move it to its own repo to no avail. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.