Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Extract browserTrigger from ngScenario #11033

Closed
Narretz opened this issue Feb 11, 2015 · 6 comments
Closed

Extract browserTrigger from ngScenario #11033

Narretz opened this issue Feb 11, 2015 · 6 comments

Comments

@Narretz
Copy link
Contributor

Narretz commented Feb 11, 2015

browserTrigger currently lives under https://github.com/angular/angular.js/blob/master/src/ngScenario/browserTrigger.js

Before ngScenario is removed, we need to move browserTrigger to a place where tests can use it like before.

Tentatively assigning @petebacondarwin

@petebacondarwin
Copy link
Contributor

Putting in the backlog for now until we get round to doing this.

@petebacondarwin petebacondarwin removed their assignment Jul 20, 2015
@petebacondarwin petebacondarwin modified the milestones: Backlog, 1.4.x Jul 20, 2015
@petebacondarwin
Copy link
Contributor

We should move browserTrigger to ngMock right? @Narretz ?

@petebacondarwin petebacondarwin modified the milestones: 1.6.x, Backlog Jun 6, 2016
@Narretz
Copy link
Contributor Author

Narretz commented Jun 6, 2016

Yes, we (I) can do it. That would also mean we have to document it - atm it's not a public API. (Not anymore, since ngScenario was deprecated and removed from the docs)

@petebacondarwin
Copy link
Contributor

Do we have to document it and make it public? Can't we just move it for now?

@Narretz
Copy link
Contributor Author

Narretz commented Jun 6, 2016

That's also an option of course ...

@thorn0
Copy link
Contributor

thorn0 commented Sep 29, 2016

#14718 was merged. Seems like this issue can be closed.

@gkalpak gkalpak closed this as completed Sep 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants