This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($animate): detail options object #14700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * - **from** - `{Object}` - CSS properties & values from beginning of animation | ||
| * - **removeClass** - `{string}` - space-separated CSS classes to remove from element | ||
| * - **to** - `{Object}` - CSS properties & values at end of animation | ||
| * |
There was a problem hiding this comment.
Could you also document the options argument of other methods (e.g. move()) ?
|
This should indeed fix #12645. Feel free to add |
wesleycho
force-pushed
the
docs/animate-options
branch
from
b5b969d to
55d0c88
Compare
| * The object has the following properties: | ||
| * | ||
| * - **addClass** - `{string}` - space-separated CSS classes to add to element | ||
| * - **from** - `{Object}` - CSS properties & values from beginning of animation |
There was a problem hiding this comment.
"from the beginning" -> "at the beginning"
- Document options object used in various $animate methods Fixes angular#12645
wesleycho
force-pushed
the
docs/animate-options
branch
from
55d0c88 to
9dc3fe4
Compare
gkalpak
pushed a commit
to gkalpak/angular.js
that referenced
this pull request
Jun 3, 2016
- Document options object used in various $animate methods Fixes angular#12645 PR: angular#14700
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #12645.