Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Document the options parameter of $animate functions #12645

Closed
djdmbrwsk opened this issue Aug 21, 2015 · 1 comment
Closed

Document the options parameter of $animate functions #12645

djdmbrwsk opened this issue Aug 21, 2015 · 1 comment

Comments

@djdmbrwsk
Copy link

Unless I missed it, there is no documentation explaining the options parameter that is optional in a bunch of the $animate service's functions. Ex:

$animate.enter(element, parent, [after], [options]);

I just spent a bit digging through the source to finally find you can pass in an object like this:

{
  addClass: 'some-new-class',
  removeClass: ' some-old-class'
}
@Narretz Narretz added this to the Backlog milestone Aug 21, 2015
@Narretz
Copy link
Contributor

Narretz commented Nov 3, 2015

@djdmbrwsk Would you like to submit a PR which adds the info to the docs?

wesleycho added a commit to wesleycho/angular.js that referenced this issue Jun 1, 2016
- Document options object used in various $animate methods

Fixes angular#12645
wesleycho added a commit to wesleycho/angular.js that referenced this issue Jun 2, 2016
- Document options object used in various $animate methods

Fixes angular#12645
@Narretz Narretz closed this as completed in 146dad7 Jun 3, 2016
Narretz pushed a commit that referenced this issue Jun 3, 2016
- Document options object used in various $animate methods

Fixes #12645
PR: #14700
gkalpak pushed a commit to gkalpak/angular.js that referenced this issue Jun 3, 2016
- Document options object used in various $animate methods

Fixes angular#12645
PR: angular#14700
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants