This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Lifecycle hook error catching #14463
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
force-pushed
the
lifecycle-hook-catching
branch
4 times, most recently
from
cbf7456 to
63ce920
Compare
| $rootScope.$apply('a = 42'); | ||
|
|
||
| // The first component's error should be logged | ||
| expect($exceptionHandler.errors[0].toString()).toEqual('Error: bad hook'); |
|
LGTM |
Previously, if one of these hooks threw an error, then any other `$onChanges` hooks that had been scheduled were not executed, nor was the queue cleaned up properly. Closes angular#14444 Closes angular#14463
Previously, if one of these hooks threw an error, then the compilation was terminated unceremoniously. Closes angular#14444 Closes angular#14463
petebacondarwin
force-pushed
the
lifecycle-hook-catching
branch
from
63ce920 to
c57ed91
Compare
Previously, if one of these hooks threw an error, then any other `$onChanges` hooks that had been scheduled were not executed, nor was the queue cleaned up properly. Closes angular#14444 Closes angular#14463
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix
What is the current behavior? (You can also link to an open issue here)
Errors in hooks are not dealt with very nicely
See #14444
What is the new behavior (if this is a feature change)?
Errors are caught and passed to the exceptionHandler in a reasonable way, without causing the application as a whole to crash
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
[ ] Docs have been added / updated (for bug fixes / features)Other information: