fix($compile): cope with $onInit hooks throwing

Previously, if one of these hooks threw an error, then the compilation
was terminated unceremoniously.

Closes #14444

Author: petebacondarwin

src/ng/compile.js

@@ -1300,7 +1300,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
           for (var i = 0, ii = onChangesQueue.length; i < ii; ++i) {
             try {
               onChangesQueue[i]();
-            } catch(e) {
+            } catch (e) {
               errors.push(e);
             }
           }
@@ -2471,12 +2471,16 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
           if (isFunction(controllerInstance.$onChanges)) {
             try {
               controllerInstance.$onChanges(controller.bindingInfo.initialChanges);
-            } catch(e) {
+            } catch (e) {
               $exceptionHandler(e);
             }
           }
           if (isFunction(controllerInstance.$onInit)) {
-            controllerInstance.$onInit();
+            try {
+              controllerInstance.$onInit();
+            } catch (e) {
+              $exceptionHandler(e);
+            }
           }
           if (isFunction(controllerInstance.$onDestroy)) {
             controllerScope.$on('$destroy', function callOnDestroyHook() {

test/ng/compileSpec.js

@@ -1,6 +1,6 @@
 'use strict';
 
-fdescribe('$compile', function() {
+describe('$compile', function() {
   function isUnknownElement(el) {
     return !!el.toString().match(/Unknown/);
   }
@@ -3563,6 +3563,46 @@ fdescribe('$compile', function() {
           expect(Controller2.prototype.$onInit).toHaveBeenCalledOnce();
         });
       });
+
+      it('should continue to trigger other `$onInit` hooks if one throws an error', function() {
+        function ThrowingController() {
+          this.$onInit = function() {
+            throw new Error('bad hook');
+          };
+        }
+        function LoggingController($log) {
+          this.$onInit = function() {
+            $log.info('onInit');
+          };
+        }
+
+        angular.module('my', [])
+          .component('c1', {
+            controller: ThrowingController,
+            bindings: {'prop': '<'}
+          })
+          .component('c2', {
+            controller: LoggingController,
+            bindings: {'prop': '<'}
+          })
+          .config(function($exceptionHandlerProvider) {
+            // We need to test with the exceptionHandler not rethrowing...
+            $exceptionHandlerProvider.mode('log');
+          });
+
+        module('my');
+        inject(function($compile, $rootScope, $exceptionHandler, $log) {
+
+          // Setup the directive with bindings that will keep updating the bound value forever
+          element = $compile('<div><c1 prop="a"></c1><c2 prop="a"></c2>')($rootScope);
+
+          // The first component's error should be logged
+          expect($exceptionHandler.errors.pop().toString()).toEqual('Error: bad hook');
+
+          // The second component's hook should still be called
+          expect($log.info.logs.pop()).toEqual(['onInit']);
+        });
+      });
     });
 
 
@@ -4113,7 +4153,9 @@ fdescribe('$compile', function() {
           $rootScope.$apply('a = 42');
 
           // Both component's error should be logged
-          expect($exceptionHandler.errors[0]).toEqual([new Error('bad hook: 42'), new Error('bad hook: 84')]);
+          var errors = $exceptionHandler.errors.pop();
+          expect(errors.pop()).toEqual(new Error('bad hook: 84'));
+          expect(errors.pop()).toEqual(new Error('bad hook: 42'));
         });
       });
     });