This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(errorDisplay): encode < and > in error messages
#14033
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an error message contains an HTML string (e.g. `$location:nobase` containing `<base>`), it was interpreted as a literal HTML element, instead of text. Error messages are not expected to render as HTML, but we still need to use `.html()` in `errorDisplay`, so that the links created by `errorLinkFilter` are properly displayed. This commit solves this issue by replacing `<`/`>` with `<`/`>`. Related to angular#14016.
|
Before: After: |
| @@ -34,6 +34,10 @@ angular.module('errors', ['ngSanitize']) | |||
|
|
|||
|
|
|||
| .directive('errorDisplay', ['$location', 'errorLinkFilter', function ($location, errorLinkFilter) { | |||
| var encodeAngularBrackets = function (text) { | |||
There was a problem hiding this comment.
encodeAngularBrackets -> encodeHtmlBrackets ?
There was a problem hiding this comment.
By Angular, @gkalpak means < and > right?
There was a problem hiding this comment.
I think "angle brackets" might be more "correct" (and certainly less confusing).
|
This looks good but I wonder if we could save some complexity by simply using a binding (which should do the escaping for us) rather than writing to |
|
@petebacondarwin, we need the HTML (because we want to render TBH, a much simpler workaround would be to change the error message to not include |
|
Nice thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error message contains an HTML string (e.g.
$location:nobasecontaining<base>), it was interpreted as a literal HTML element, instead of text. Error messages are not expected to render as HTML, but we still need to use.html()inerrorDisplay, so that the links created byerrorLinkFilterare properly displayed.This commit solves this issue by replacing
</>with</>.Related to #14016.
There is also another commit that adds some tests for the
errorsmodule of the docs app.