Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(error/nobase): tag base wasn't displayed properly #13964

Closed
wants to merge 1 commit into from
Closed

docs(error/nobase): tag base wasn't displayed properly #13964

wants to merge 1 commit into from

Conversation

saamed
Copy link

@saamed saamed commented Feb 7, 2016

Replaced < with &lt and > with >

Replaced < with &lt and > with &gt;
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@saamed
Copy link
Author

saamed commented Feb 7, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Feb 7, 2016
@petebacondarwin
Copy link
Contributor

It looks like it is rendering properly for me...

screen shot 2016-02-08 at 02 15 25

You should not need to escape HTML characters in code blocks.

@Narretz
Copy link
Contributor

Narretz commented Feb 8, 2016

@petebacondarwin In the code block above the Description, there's a gap where <base> should be. I tried to fix this before. Let me see if I still have a branch with a fix.

@petebacondarwin
Copy link
Contributor

OK but that is not the problem that this PR is trying to fix

@Narretz
Copy link
Contributor

Narretz commented Feb 15, 2016

See #14033

@Narretz Narretz closed this Feb 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants