Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngAnimate): Provide information about what class is being added for addClass and removeClass events #13059

Closed
wants to merge 1 commit into from
Closed

fix(ngAnimate): Provide information about what class is being added for addClass and removeClass events #13059

wants to merge 1 commit into from

Conversation

fhernandezn
Copy link

Hi everyone!

This pull request is related to the issue #12697 about the lack of information for the events addClass and removeClass.

Please review the code and let me know is something is wrong,

Closes #12697

@fhernandezn fhernandezn changed the title Provide information about what class is being added for addClass and removeClass events fix(ngAnimate): Provide information about what class is being added for addClass and removeClass events Oct 9, 2015
@Ariel-Isaacm
Copy link

Hey! good job, your solution is pretty neat :) it looks pretty good to me

@fhernandezn
Copy link
Author

Hi @Narretz could you take a look to my PR?

@Narretz Narretz added this to the Backlog milestone Nov 30, 2015
@Narretz
Copy link
Contributor

Narretz commented Nov 30, 2015

Thanks for the PR. A few things should be done / considered:

  • Make sure the object passed to the notify fn is always structured the same (so it should always have the addClass and removeClass properties, and they should be null if nothing is set).
  • Should the other options also be passed to the notifier / events?
  • The behavior needs to be tested.

@Narretz Narretz modified the milestones: Backlog, 1.7.x Jun 20, 2018
Narretz added a commit to Narretz/angular.js that referenced this pull request Jul 3, 2018
@Narretz
feat($animate): add option data to event callbacks
0b91b93 
Closes angular#12697
Closes angular#13059
Narretz added a commit to Narretz/angular.js that referenced this pull request Jul 9, 2018
@Narretz
feat($animate): add option data to event callbacks
2b88975 
Closes angular#12697
Closes angular#13059
Narretz added a commit to Narretz/angular.js that referenced this pull request Jul 9, 2018
@Narretz
feat($animate): add option data to event callbacks
a945e00 
Closes angular#12697
Closes angular#13059
@Narretz Narretz closed this in e4339bc Jul 9, 2018
Narretz added a commit that referenced this pull request Jul 9, 2018
@Narretz
feat($animate): add option data to event callbacks
fc64e68 
Closes #12697
Closes #13059
@dependencies dependencies bot mentioned this pull request Aug 9, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes component: ngAnimate needs: test needs: work type: feature
Projects
None yet
Milestone
1.7.x
Development

Successfully merging this pull request may close these issues.
4 participants
@fhernandezn @Ariel-Isaacm @Narretz @googlebot