Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

$animate.on('addClass') etc do not provide enough info #12697

Closed
jamie-pate opened this issue Aug 28, 2015 · 1 comment
Closed

$animate.on('addClass') etc do not provide enough info #12697

jamie-pate opened this issue Aug 28, 2015 · 1 comment
Assignees
@Narretz
Labels
component: ngAnimate type: feature
Milestone
1.7.x

Comments

@jamie-pate
Copy link

What class is being added? i don't know! The current implementation (1.4.3) only passes in an empty object {} as 'data'

angular.js/src/ngAnimate/animateQueue.js

Line 450 in ea8016c

notifyProgress(runner, event, 'close', {});

@matsko
Copy link
Contributor

matsko commented Aug 31, 2015

That's a good point. We should add that info.

@Narretz Narretz added this to the 1.4.x milestone Aug 31, 2015
@fhernandezn fhernandezn mentioned this issue Oct 9, 2015
Closed
@Narretz Narretz modified the milestones: 1.4.x, 1.5.x May 27, 2016
@Narretz Narretz modified the milestones: 1.5.x, 1.7.x Apr 12, 2018
@Narretz Narretz self-assigned this May 3, 2018
Narretz added a commit to Narretz/angular.js that referenced this issue Jul 3, 2018
@Narretz
feat($animate): add option data to event callbacks
0b91b93 
Closes angular#12697
Closes angular#13059
Narretz added a commit to Narretz/angular.js that referenced this issue Jul 9, 2018
@Narretz
feat($animate): add option data to event callbacks
2b88975 
Closes angular#12697
Closes angular#13059
Narretz added a commit to Narretz/angular.js that referenced this issue Jul 9, 2018
@Narretz
feat($animate): add option data to event callbacks
a945e00 
Closes angular#12697
Closes angular#13059
@Narretz Narretz closed this as completed in e4339bc Jul 9, 2018
Narretz added a commit that referenced this issue Jul 9, 2018
@Narretz
feat($animate): add option data to event callbacks
fc64e68 
Closes #12697
Closes #13059
@dependencies dependencies bot mentioned this issue Aug 9, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Narretz Narretz

Labels
component: ngAnimate type: feature
Projects
None yet
Milestone
1.7.x
Development

No branches or pull requests
3 participants
@matsko @jamie-pate @Narretz