Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor: use isDefined and isUndefined consistently #12831

Closed
wants to merge 2 commits into from
Closed

refactor: use isDefined and isUndefined consistently #12831

wants to merge 2 commits into from

Conversation

lucastetreault
Copy link
Contributor

Fix any place that x == undefined or x != undefined
to use isUndefined and isDefined instead

Closes #4365

Fix any place that x == undefined or x != undefined
to use isUndefined and isDefined instead

Closes #4365
Fix any place that x == undefined or x != undefined
to use isUndefined and isDefined instead

Closes #4365
@lgalfaso
Copy link
Contributor

Hi, thanks for the PR. Can you please

  • Squash everything into a single commit
  • Fix the commit comment as this is not changing x == undefined and x != undefined as it is changing x === undefined and x !== undefined (that have a slightly different meaning)

@lgalfaso lgalfaso added this to the 1.5.x - migration-facilitation milestone Sep 12, 2015
@lgalfaso lgalfaso self-assigned this Sep 12, 2015
@petebacondarwin
Copy link
Contributor

@lgalfaso thanks for triaging this one. I think that if it looks good then we can do the squash and commit message fix up when merging to save on cycles.

Thanks @lucastetreault for fixing this very long running issue!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants