You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
I noticed the functions isUndefined and isDefined in src/Angular.js, which seems like a good idea to standardise the checking of defined/undefined variables. However, I noticed that still checks for undefined/defined are done without these functions in quite some places throughout the code. Have a look at the equals function defined in src/Angular.js around line 752, as an example. There the statement o2[key] !== undefinedcan be found. It seems to me that this should instead be isDefined(o2[key]) to keep the consistency and obey the defined/undefined check standardisation.
tl;dr; Only isDefinedand `isUndefined`` should be used the check for undefined/defined variables.
If this is desired, I would happily create a pull request fixing this.
The text was updated successfully, but these errors were encountered:
I noticed the functions
isUndefined
andisDefined
in src/Angular.js, which seems like a good idea to standardise the checking of defined/undefined variables. However, I noticed that still checks for undefined/defined are done without these functions in quite some places throughout the code. Have a look at theequals
function defined in src/Angular.js around line 752, as an example. There the statemento2[key] !== undefined
can be found. It seems to me that this should instead beisDefined(o2[key])
to keep the consistency and obey the defined/undefined check standardisation.tl;dr; Only
isDefined
and `isUndefined`` should be used the check for undefined/defined variables.If this is desired, I would happily create a pull request fixing this.
The text was updated successfully, but these errors were encountered: