This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(ngAnimate): change .ng-enter to .ng-animate #12202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.ng-enter class is not added by animateCss service. .enter and .ng-animate is added. Maybe a fix of adding .ng-enter rather than .enter is more proper.
|
Indeed it seems that the Also, the examples on https://docs.angularjs.org/api/ngAnimate seem rather outdated (and have several types (e.g. missing closing Demo with the example fixed (although other examples need fixing as well, plus there is the |
|
No the CSS code is right, but we forgot to add the property that instructs |
|
This fix has taken care of that: 344dffb |
|
Thank you for bringing this up. |
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
gkalpak
referenced
this pull request
Sep 18, 2015
ggershoni
pushed a commit
to ggershoni/angular.js
that referenced
this pull request
Sep 29, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.ng-enter class is not added by animateCss service. .enter and .ng-animate is added. Maybe a fix of adding .ng-enter rather than .enter is more proper.