-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs(ngAnimate): Change event to ng-enter #11833
Conversation
The event needs to map to the css class, or else the css class won't fire
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
@matsko - can you check this is correct and merge? |
This doesn't seem correct (unless the documentation is wrong). |
It seem to me that the original wording is correct. See https://github.com/angular/angular.js/blob/master/src/ngAnimate/animateCss.js#L185 |
The problem is that in practice, it doesn't work as described in the docs (but I think there is another issue about this). |
Can you provide a demo of this not working? |
I am pretty sure there was another issue (where I had commented) that showed the issue with @matsko has pushed some fixes that may have taken care of the issue. I'll check and create a demo if it hasn't been fixed on master. |
I found it: the issue is #12202 (which is not directily related, but lead me to noticing the unexpected(?) behaviour). Here is the demo, I created for that issue. |
The event needs to map to the css class, or else the css class won't fire