This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAria): Ensure aria-hidden attribute is always "true" or "false" #11865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when using ngAria with and ng-hide directive, when value passed to ng-hide is not boolean, aria-hidden attribute is set to an invalid value. This fix ensures aria-hidden attribute is always either "true" or "false".
Narretz
pushed a commit
to Narretz/angular.js
that referenced
this pull request
May 28, 2015
Previously, when using ngAria with the ng-hide directive, and the value passed to ng-hide was not boolean, the aria-hidden attribute was set to this non-boolean value. Closes angular#11865
Narretz
pushed a commit
to Narretz/angular.js
that referenced
this pull request
May 28, 2015
Previously, when using ngAria with the ng-hide directive, and the value passed to ng-hide was not boolean, the aria-hidden attribute was set to this non-boolean value. Closes angular#11865
Narretz
pushed a commit
to Narretz/angular.js
that referenced
this pull request
Jun 1, 2015
…lse" Previously, when using ngAria with the ng-hide directive, and the value passed to ng-hide was not boolean, the aria-hidden attribute was set to this non-boolean value. Closes angular#11865
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
…lse" Previously, when using ngAria with the ng-hide directive, and the value passed to ng-hide was not boolean, the aria-hidden attribute was set to this non-boolean value. Closes angular#11865 Closes angular#11998
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using ngAria with ng-hide directive when value passed
to ng-hide is not boolean aria-hidden attribute is set to an invalid value.
This fix ensures aria-hidden attribute is always either "true" or "false".
Fixes #11365 as well.