You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Using Angular 1.4.0 - It appears that ngAria causes the ngDisabled directive to apply aria-disabled="value" even when the ng-disabled expression is not explicitly returning TRUE.
I discovered this when I was using an OR based expression like the following:
I found that while ngDisabled properly applies or unapplies the disabled="disabled" attribute to the button when this expression did not return an explicit TRUE value, ngAria did not unapply the aria-disabled attribute when the expression did not return an explicit TRUE value (returning undefined).
It seems that in my "Undefined Example" you can see that 'undefined' perhaps gets converted to TRUE when assigned to the scope via ngModel.
I'm not completely sure what is causing that, as the "Simple Example" you see it's applying aria-disabled="undefined". I'm not sure if this is what it's receiving from $scope.undefined, or if it's evaluating the 'undefined' in the attribute as a string or as an actual undefined value.
The text was updated successfully, but these errors were encountered:
…lse"
Previously, when using ngAria with the ng-hide directive,
and the value passed to ng-hide was not boolean,
the aria-hidden attribute was set to this non-boolean value.
Closesangular#11865Closesangular#11998
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Using Angular 1.4.0 - It appears that ngAria causes the ngDisabled directive to apply
aria-disabled="value"
even when the ng-disabled expression is not explicitly returning TRUE.I discovered this when I was using an OR based expression like the following:
I found that while ngDisabled properly applies or unapplies the
disabled="disabled"
attribute to the button when this expression did not return an explicit TRUE value, ngAria did not unapply the aria-disabled attribute when the expression did not return an explicit TRUE value (returning undefined).Here is a jsFiddle example.
It seems that in my "Undefined Example" you can see that 'undefined' perhaps gets converted to TRUE when assigned to the scope via ngModel.
I'm not completely sure what is causing that, as the "Simple Example" you see it's applying
aria-disabled="undefined"
. I'm not sure if this is what it's receiving from $scope.undefined, or if it's evaluating the 'undefined' in the attribute as a string or as an actual undefined value.The text was updated successfully, but these errors were encountered: