Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(angular.element): css() api incompatibility. #11614

Closed
wants to merge 1 commit into from
Closed

docs(angular.element): css() api incompatibility. #11614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/jqLite.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
* - [`children()`](http://api.jquery.com/children/) - Does not support selectors
* - [`clone()`](http://api.jquery.com/clone/)
* - [`contents()`](http://api.jquery.com/contents/)
* - [`css()`](http://api.jquery.com/css/) - Only retrieves inline-styles, does not call `getComputedStyle()`
* - [`css()`](http://api.jquery.com/css/) - Only retrieves inline-styles, does not call `getComputedStyle()`. On write, does not convert numbers to strings and append 'px'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be:

On write, does not convert numbers to strings or append 'px'.

? Native speaker required. ;-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this line is too long, it should be broken.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the wording but not the line length. Next time!

----- Ursprüngliche Nachricht -----
Von: "Michał Gołębiowski" [email protected]
Gesendet: ‎27.‎04.‎2015 22:35
An: "angular/angular.js" [email protected]
Cc: "Martin Staffa" [email protected]
Betreff: Re: [angular.js] docs(angular.element): css() api incompatibility.(#11614)

In src/jqLite.js:

@@ -55,7 +55,7 @@

  • - children() - Does not support selectors
  • - clone()
  • - contents()
    • * - css() - Only retrieves inline-styles, does not call getComputedStyle()
    • * - css() - Only retrieves inline-styles, does not call getComputedStyle(). On write, does not convert numbers to strings and append 'px'.
      Also, this line is too long, it should be broken.
      —
      Reply to this email directly or view it on GitHub.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a native speaker either, but I think it should be "nor" :)
(Just noting for next time.)

* - [`data()`](http://api.jquery.com/data/)
* - [`detach()`](http://api.jquery.com/detach/)
* - [`empty()`](http://api.jquery.com/empty/)
Expand Down