This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(angular.element): css() api incompatibility. #11614
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"When a number is passed as the value, jQuery will convert it to a string and add px to the end of that string." http://api.jquery.com/css/#css2 jqLite does not appear to do this. I can submit if fix desired.
|
Not sure why test is failing, the change is trivial. |
|
It's OK now :) |
caitp
pushed a commit
to caitp/angular-drop
that referenced
this pull request
Apr 17, 2015
Notes: - $dndDOM contains DOM helpers based on those from angular-ui/bootstrap and jQuery - Removed draggable.positionAbs - Fix issue when using jqLite's css implementation (angular/angular.js#11614) - Manually tested on IE9 Closes #64 Closes #63
| @@ -55,7 +55,7 @@ | |||
| * - [`children()`](http://api.jquery.com/children/) - Does not support selectors | |||
| * - [`clone()`](http://api.jquery.com/clone/) | |||
| * - [`contents()`](http://api.jquery.com/contents/) | |||
| * - [`css()`](http://api.jquery.com/css/) - Only retrieves inline-styles, does not call `getComputedStyle()` | |||
| * - [`css()`](http://api.jquery.com/css/) - Only retrieves inline-styles, does not call `getComputedStyle()`. On write, does not convert numbers to strings and append 'px'. | |||
There was a problem hiding this comment.
Shouldn't it be:
On write, does not convert numbers to strings or append 'px'.
? Native speaker required. ;-)
There was a problem hiding this comment.
Also, this line is too long, it should be broken.
There was a problem hiding this comment.
I fixed the wording but not the line length. Next time!
----- Ursprüngliche Nachricht -----
Von: "Michał Gołębiowski" [email protected]
Gesendet: 27.04.2015 22:35
An: "angular/angular.js" [email protected]
Cc: "Martin Staffa" [email protected]
Betreff: Re: [angular.js] docs(angular.element): css() api incompatibility.(#11614)
In src/jqLite.js:
@@ -55,7 +55,7 @@
- -
children()- Does not support selectors- -
clone()- -
contents()
- * -
css()- Only retrieves inline-styles, does not callgetComputedStyle()- * -
css()- Only retrieves inline-styles, does not callgetComputedStyle(). On write, does not convert numbers to strings and append 'px'.
Also, this line is too long, it should be broken.
—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Not a native speaker either, but I think it should be "nor" :)
(Just noting for next time.)
Narretz
pushed a commit
that referenced
this pull request
Apr 27, 2015
"When a number is passed as the value, jQuery will convert it to a string and add px to the end of that string." http://api.jquery.com/css/#css2 jqLite does not appear to do this. I can submit if fix desired. Closes #11614
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
"When a number is passed as the value, jQuery will convert it to a string and add px to the end of that string." http://api.jquery.com/css/#css2 jqLite does not appear to do this. I can submit if fix desired. Closes angular#11614
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"When a number is passed as the value, jQuery will convert it to a string and add px to the end of that string."
http://api.jquery.com/css/#css2
jqLite does not appear to do this.
Partial fix for #11626 .
(can submit full fix if desired)