chore(docs): mark builds >= 1.3.0 as stable #10117
Conversation
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
Update isStable() to add builds >= 1.3.0 marked as stable. Previously, only builds with an even minor version number (1.0.x, 1.2.x) were marked as stable, while odd minor numbers (1.3.x) were marked as unstable. Now, 1.0.x, 1.2.x and 1.3+ will all be marked as stable. Prereleases remain marked as unstable, regardless of minor version.
royaldark
force-pushed
the
fix-version-stability
branch
from
aa8e625 to
d1f2dbc
Compare
|
@mary-poppins I used the wrong email in my original commit. Fixed. |
|
CLA verified, thank you! |
| @@ -97,7 +97,7 @@ var getTaggedVersion = function() { | |||
| * @return {Boolean} True if the version is stable | |||
| */ | |||
| var isStable = function(version) { | |||
| return semver.satisfies(version, '1.0 || 1.2') && version.prerelease.length === 0; | |||
| return semver.satisfies(version, '1.0 || 1.2 || >=1.3') && version.prerelease.length === 0; | |||
There was a problem hiding this comment.
I think this is not what we want. It should be '1.0 || 1.2 || >=1.3 <1.4.0'
|
see #10053 |
|
Fixed by addb4bd |
Update isStable() to add builds >= 1.3.0 marked as stable. Previously, only builds with an even minor version number (1.0.x, 1.2.x) were marked as stable, while odd minor numbers (1.3.x) were marked as unstable. Now, 1.0.x, 1.2.x and 1.3+ will all be marked as stable. Prereleases remain marked as unstable, regardless of minor version.
As noted here, odd minor versions are no longer considered unstable.
See screenshot of the current (incorrect) behavior:
