Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Improve this Doc button on docs.angularjs.org doesn't work #3246

Closed
naomiblack opened this issue Jul 16, 2013 · 14 comments
Closed

Improve this Doc button on docs.angularjs.org doesn't work #3246

naomiblack opened this issue Jul 16, 2013 · 14 comments

Comments

@naomiblack
Copy link
Contributor

The button should link to the docs repo but it doesn't seem to be working.

@petebacondarwin
Copy link
Contributor

Works for me. On which specific page are you clicking the button and what do you see?

@naomiblack
Copy link
Contributor Author

Try the button on the tutorial page, here: http://docs.angularjs.org/tutorial/step_00
Behavior is no cursor change on mouseover, and nothing happens when you click.

@petebacondarwin
Copy link
Contributor

Right, you can't click on it!

On 16 July 2013 23:46, naomiblack [email protected] wrote:

Try the button on the tutorial page, here:
http://docs.angularjs.org/tutorial/step_00


Reply to this email directly or view it on GitHubhttps://github.com//issues/3246#issuecomment-21079940
.

@petebacondarwin
Copy link
Contributor

The <ul> is hiding the <a> and stopping it from being clickable.

On 17 July 2013 08:32, Peter Bacon Darwin [email protected] wrote:

Right, you can't click on it!

On 16 July 2013 23:46, naomiblack [email protected] wrote:

Try the button on the tutorial page, here:
http://docs.angularjs.org/tutorial/step_00


Reply to this email directly or view it on GitHubhttps://github.com//issues/3246#issuecomment-21079940
.

@petebacondarwin
Copy link
Contributor

@matsko - any idea how to fix this? I have just spent about a hour hacking around with the CSS and HTML...

@matsko
Copy link
Contributor

matsko commented Jul 17, 2013

Try setting the zIndex on the button <a> element.

position:relative;
z-index:2000;

@petebacondarwin
Copy link
Contributor

Tried that!

On 17 July 2013 14:06, Matias Niemelä [email protected] wrote:

Try setting the zIndex:

position:relative;z-index:2000;


Reply to this email directly or view it on GitHubhttps://github.com//issues/3246#issuecomment-21111160
.

@matsko
Copy link
Contributor

matsko commented Jul 18, 2013

This fixes it. Basically it does float sometimes and it does position absolute sometimes. So you need to use position relative when float is set and keep absolute when there is no float. #3261

@matsko
Copy link
Contributor

matsko commented Oct 1, 2013

This has been working for a while. Closing! :)

@matsko matsko closed this as completed Oct 1, 2013
@danielmcormond
Copy link

@petebacondarwin @matsko I believe the 404's are also happening when you are not logged in to GitHub.

For example, try opening this link in an incognito window.

Probably nothing we can do about that, but I noticed it was confusing some folks in #angularjs.

I commented on this issue as it was the most recent related issue I could find.

@edhedges
Copy link
Contributor

edhedges commented Mar 7, 2014

@matsko I'm having this issue in Chrome Version 33.0.1750.146 for Mac OS X 10.9.2. Just wanted to let you guys know. I just inspected the element and clicked the link that way.

@matsko
Copy link
Contributor

matsko commented Mar 10, 2014

@edhedges can you open a new issue? This one is kinda old.

@edhedges
Copy link
Contributor

@matsko done

@matsko
Copy link
Contributor

matsko commented Mar 10, 2014

Good stuff.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants