-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Twitter Bootstrap Responsive Navbar broken with 1.0.3 release #1674
Comments
+1 |
Same problem with angular 1.1.1 |
+1 for 1.0.3, no errors anywhere. Actually, I've just re-ordered my build and it's working OK angular, angular-resource, jQuery, bootstrap* Originally had jQuery & bootstrap first due to this exact issue (collapse not working); haven't tested further as yet. |
@nodokodo - i'll be a monkey's uncle -- if you re-order as follows:
It does fix it! jsfiddle updated: http://jsfiddle.net/ghtC9/6/ Unfortunately, this causes a host of other issues. I'm also using angular-ui, and it fails horribly if I re-order so jquery loads after angular. |
I had the same issue in my application until I changed
to
that is, I added href="#" to the anchor tag. |
@shahmirn that's the ticket, cheers |
Seems related to the click issue with jQuery when no href is given. That should explain why adding the href="#" fixes the problem. Problem is, when using a dropdown, if each |
This is caused by c81d817. Quick fix: comment out "return false". |
I'd close this issue is caused by click event not propagating. (#1651) |
In case it helps anyone, I change the anchor tag to a button tag, and it works nicely. The problem with add href="#" to the a-tag is that when you click the dropdown button, angular will redirect you to your homepage route. I've only done a little testing, but it seems to work. This is the article that I read that helped: http://onehungrymind.com/quick-note-ng-disabled-and-anchor-tags-oh-noes/ |
fixed by 14948cf |
This reverts commit c81d817. This commit causes several issues (angular#1651, angular#1674, angular#1662) and doesn't even contain a test that proves that anything on Opera got actually fixed. If the original Opera resurfaces, we'll fix it properly.
Hi, I'm trying to use the Twitter Bootstrap responsive Navbar with AngularJS. When I upgraded from 1.0.2 to 1.0.3 the responsive navbar feature stopped working.
The responsive features work in terms of the viewport changing layout when resized, but under a smaller viewport, you can no longer click on the button to expand the navbar menu.
I created a jsfiddle example here: http://jsfiddle.net/ghtC9/2/ that includes angular-1.0.3.js
The HTML code was cut/paste from the bootstrap example for Responsive Navbar (section found under here):
Here's the same jsfiddle http://jsfiddle.net/ghtC9/5/ that includes angular-1.0.2.js -- note that the menu button now expands when clicked.
I tried loading them in different orders: 1) bootstrap 2) angular vs. 1) angular 2) bootstrap - makes no difference.
There is nothing in the console giving any indication of an error.
The text was updated successfully, but these errors were encountered: